Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add name-length of dummy interface too long error #1875

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

8rxn
Copy link
Contributor

@8rxn 8rxn commented Dec 26, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new validation for dummy interface length not to exceed 15 chars.

Which issue(s) this PR fixes:

Fixes #1867

Special notes for your reviewer:

/@rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rambohe-ch
Copy link
Member

@8rxn Thank you for your good job.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (74b0a47) 52.20% compared to head (5ab2b82) 52.19%.
Report is 4 commits behind head on master.

Files Patch % Lines
cmd/yurthub/app/options/options.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1875      +/-   ##
==========================================
- Coverage   52.20%   52.19%   -0.01%     
==========================================
  Files         172      172              
  Lines       20839    20842       +3     
==========================================
  Hits        10879    10879              
- Misses       8997     8999       +2     
- Partials      963      964       +1     
Flag Coverage Δ
unittests 52.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/rerun

1 similar comment
@rambohe-ch
Copy link
Member

/rerun

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Dec 28, 2023
@rambohe-ch rambohe-ch merged commit 817f679 into openyurtio:master Dec 28, 2023
12 of 13 checks passed
@rambohe-ch rambohe-ch added the backport release-v1.4 backport release-v1.4 label Feb 20, 2024
@rambohe-ch
Copy link
Member

/backport release-v1.4

Copy link

Successfully created backport PR for release-v1.4:

zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.4 backport release-v1.4 lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]the name length of dummy interface should be under 15 chars.
2 participants