Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add NodeBucket to reduce cloud-edge traffic spike during rapid node additions. #1864

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation

What this PR does / why we need it:

Add a proposal to reduce cloud-edge traffic spike during rapid node additions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation

What this PR does / why we need it:

Add a proposal to reduce cloud-edge traffic spike during rapid node additions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/documentation kind/documentation label Dec 19, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/M size/M: 30-99 labels Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c1dde7) 52.14% compared to head (a086580) 52.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
+ Coverage   52.14%   52.20%   +0.05%     
==========================================
  Files         172      172              
  Lines       20839    20839              
==========================================
+ Hits        10867    10879      +12     
+ Misses       9008     8997      -11     
+ Partials      964      963       -1     
Flag Coverage Δ
unittests 52.20% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch force-pushed the add-nodebucket-proposal branch from db924a8 to 5f3c820 Compare December 19, 2023 07:35
@rambohe-ch rambohe-ch force-pushed the add-nodebucket-proposal branch from 5f3c820 to a086580 Compare December 26, 2023 03:25
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.7% Duplication on New Code

See analysis details on SonarCloud

@JameKeal
Copy link
Member

/lgtm

@JameKeal
Copy link
Member

/approve

@rambohe-ch rambohe-ch requested a review from JameKeal December 26, 2023 09:56
@JameKeal JameKeal merged commit 9fb701e into openyurtio:master Dec 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/documentation kind/documentation size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants