Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace string var by const #1839

Merged
merged 1 commit into from
Dec 7, 2023
Merged

replace string var by const #1839

merged 1 commit into from
Dec 7, 2023

Conversation

dsy3502
Copy link

@dsy3502 dsy3502 commented Dec 5, 2023

replace string var by const

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Dec 5, 2023
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4147dd6) 52.19% compared to head (251506e) 52.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1839   +/-   ##
=======================================
  Coverage   52.19%   52.20%           
=======================================
  Files         172      172           
  Lines       20825    20825           
=======================================
+ Hits        10869    10871    +2     
+ Misses       8994     8993    -1     
+ Partials      962      961    -1     
Flag Coverage Δ
unittests 52.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsy3502, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Dec 7, 2023
@rambohe-ch rambohe-ch merged commit 6362870 into openyurtio:master Dec 7, 2023
14 of 15 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants