-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yurtadm join ignorePreflightErrors could not set all #1837
fix: yurtadm join ignorePreflightErrors could not set all #1837
Conversation
Signed-off-by: Liang Deng <[email protected]>
@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rambohe-ch @huiwq1990 PTAL |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1837 +/- ##
==========================================
- Coverage 52.16% 52.16% -0.01%
==========================================
Files 172 172
Lines 20836 20839 +3
==========================================
+ Hits 10870 10871 +1
- Misses 9005 9006 +1
- Partials 961 962 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@huiwq1990 PTAL |
/backport release-v1.4 |
Successfully created backport PR for |
…#1837) Signed-off-by: Liang Deng <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1836
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note