Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yurtadm join ignorePreflightErrors could not set all #1837

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 30, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1836

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1836

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Nov 30, 2023
@openyurt-bot openyurt-bot added approved approved size/S size/S 10-29 labels Nov 30, 2023
@YTGhost
Copy link
Member Author

YTGhost commented Nov 30, 2023

@rambohe-ch @huiwq1990 PTAL

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc8b77d) 52.16% compared to head (9a7a709) 52.16%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1837      +/-   ##
==========================================
- Coverage   52.16%   52.16%   -0.01%     
==========================================
  Files         172      172              
  Lines       20836    20839       +3     
==========================================
+ Hits        10870    10871       +1     
- Misses       9005     9006       +1     
- Partials      961      962       +1     
Flag Coverage Δ
unittests 52.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

@huiwq1990 PTAL

@rambohe-ch rambohe-ch merged commit 6791cc1 into openyurtio:master Dec 7, 2023
15 checks passed
@rambohe-ch rambohe-ch added the backport release-v1.4 backport release-v1.4 label Feb 20, 2024
@rambohe-ch
Copy link
Member

/backport release-v1.4

Copy link

Successfully created backport PR for release-v1.4:

zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.4 backport release-v1.4 kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] yurtadm join ignorePreflightErrors could not set all
3 participants