Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return Forbidden is appropriate #1826

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

lilongfeng0902
Copy link
Member

@lilongfeng0902 lilongfeng0902 commented Nov 23, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / why we need it:

none

Which issue(s) this PR fixes:

Fixes #1823

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

other Note

none

@openyurt-bot
Copy link
Collaborator

@lilongfeng0902: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

none

Which issue(s) this PR fixes:

Fixes #1823

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

other Note

none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Nov 23, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 23, 2023
@rambohe-ch
Copy link
Member

@lilongfeng0902 by the way, you can check the issue #1823 , there are another three Invalid places that need to be modified.

@openyurt-bot openyurt-bot added size/M size/M: 30-99 size/XS size/XS: 0-9 and removed size/XS size/XS: 0-9 size/M size/M: 30-99 labels Nov 25, 2023
@lilongfeng0902
Copy link
Member Author

@lilongfeng0902 by the way, you can check the issue #1823 , there are another three Invalid places that need to be modified.

Year, really needs to be modified.

@openyurt-bot openyurt-bot added size/M size/M: 30-99 size/XS size/XS: 0-9 and removed size/XS size/XS: 0-9 size/M size/M: 30-99 labels Nov 25, 2023
@YTGhost
Copy link
Member

YTGhost commented Nov 25, 2023

/rerun

@rambohe-ch
Copy link
Member

@lilongfeng0902 you also need to fix unit test error.

image

@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4147dd6) 52.19% compared to head (ff60a67) 52.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1826   +/-   ##
=======================================
  Coverage   52.19%   52.20%           
=======================================
  Files         172      172           
  Lines       20825    20825           
=======================================
+ Hits        10869    10871    +2     
+ Misses       8994     8993    -1     
+ Partials      962      961    -1     
Flag Coverage Δ
unittests 52.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Dec 3, 2023
@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/M size/M: 30-99 labels Dec 3, 2023
Copy link

sonarqubecloud bot commented Dec 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lilongfeng0902
Copy link
Member Author

@lilongfeng0902 you also need to fix unit test error.

image

I have fixed it, please check it again, thanks!

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilongfeng0902, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Dec 7, 2023
@rambohe-ch rambohe-ch merged commit 4bd9e61 into openyurtio:master Dec 7, 2023
15 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]it is not appropriate to return Invalid in nodepool webhook
4 participants