-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return Forbidden is appropriate #1826
Conversation
@lilongfeng0902: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/yurtmanager/webhook/nodepool/v1beta1/nodepool_validation.go
Outdated
Show resolved
Hide resolved
@lilongfeng0902 by the way, you can check the issue #1823 , there are another three |
84bd204
to
cb01b17
Compare
Year, really needs to be modified. |
ed9bebc
to
34837d6
Compare
/rerun |
@lilongfeng0902 you also need to fix unit test error. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1826 +/- ##
=======================================
Coverage 52.19% 52.20%
=======================================
Files 172 172
Lines 20825 20825
=======================================
+ Hits 10869 10871 +2
+ Misses 8994 8993 -1
+ Partials 962 961 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: 李龙峰 <[email protected]>
2a3048b
to
f04ef1e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I have fixed it, please check it again, thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilongfeng0902, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: 李龙峰 <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
none
Which issue(s) this PR fixes:
Fixes #1823
Special notes for your reviewer:
Does this PR introduce a user-facing change?
none
other Note
none