Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify yurt-manager client's default qps and burst #1825

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

lilongfeng0902
Copy link
Member

@lilongfeng0902 lilongfeng0902 commented Nov 23, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1822

Special notes for your reviewer:

none

Does this PR introduce a user-facing change?

modify yurt-manager client's default qps and burst

other Note

modify yurt-manager client's default qps and burst

@openyurt-bot
Copy link
Collaborator

@lilongfeng0902: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
fix 1822

Special notes for your reviewer:

none

Does this PR introduce a user-facing change?

modify yurt-manager client's default qps and burst

other Note

modify yurt-manager client's default qps and burst

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Nov 23, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 23, 2023
modify yurt-manager client's default qps and burst
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.4% 9.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63c1322) 52.18% compared to head (aafa4d6) 52.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1825   +/-   ##
=======================================
  Coverage   52.18%   52.18%           
=======================================
  Files         172      172           
  Lines       20843    20843           
=======================================
  Hits        10877    10877           
  Misses       9005     9005           
  Partials      961      961           
Flag Coverage Δ
unittests 52.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@luckymrwang luckymrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilongfeng0902, luckymrwang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [luckymrwang,rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

@lilongfeng0902 It's a good job, Thank you

@rambohe-ch rambohe-ch merged commit 8d7c4fd into openyurtio:master Nov 24, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]modify yurt-manager client's default qps and burst
4 participants