Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] High Availability of Edge Services Proposal #1816

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

Rui-Gan
Copy link
Member

@Rui-Gan Rui-Gan commented Nov 21, 2023

What type of PR is this?

/kind design

What this PR does / why we need it:

For multi-instance service applications within the same edge node pool, design and implement a high-availability solution at the network layer to ensure that client requests are not forwarded to faulty service instances. Moreover, it should be capable of distributing requests to healthy service endpoints according to a predetermined policy.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Rui-Gan: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind design

What this PR does / why we need it:

For multi-instance service applications within the same edge node pool, design and implement a high-availability solution at the network layer to ensure that client requests are not forwarded to faulty service instances. Moreover, it should be capable of distributing requests to healthy service endpoints according to a predetermined policy.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Nov 21, 2023
@Rui-Gan
Copy link
Member Author

Rui-Gan commented Nov 22, 2023

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Nov 22, 2023
Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We need to add introduction for modifying kernel parameters.
  • When synchronizing keepalived, try not to break user-defined configurations.
  • The use of keepalived containers could be reflected in the proposal, we need to use the osixia/keepalived image in the Pod.

@rambohe-ch
Copy link
Member

  1. we need to define a new LoadBalancerClass for the service, and then YurtLB and speaker client only handle this kind of service.
  2. we do not support user to modify vip directly through keepalived configuration file in the first stage.

@rambohe-ch
Copy link
Member

by the way, please fix the markdown file errors.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0558530) 52.20% compared to head (2b4f865) 52.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   52.20%   52.20%           
=======================================
  Files         172      172           
  Lines       20828    20828           
=======================================
  Hits        10874    10874           
  Misses       8993     8993           
  Partials      961      961           
Flag Coverage Δ
unittests 52.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rui-Gan
Copy link
Member Author

Rui-Gan commented Nov 26, 2023

/assign @wangxye

@openyurt-bot
Copy link
Collaborator

@Rui-Gan: GitHub didn't allow me to assign the following users: wangxye.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wangxye

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rui-Gan
Copy link
Member Author

Rui-Gan commented Nov 26, 2023

/assign @LavenderQAQ

@Rui-Gan
Copy link
Member Author

Rui-Gan commented Dec 4, 2023

/rerun

1 similar comment
@Rui-Gan
Copy link
Member Author

Rui-Gan commented Dec 4, 2023

/rerun

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added lgtm lgtm approved approved labels Dec 5, 2023
@Rui-Gan
Copy link
Member Author

Rui-Gan commented Dec 5, 2023

/unhold

@Rui-Gan Rui-Gan marked this pull request as draft December 11, 2023 07:44
Signed-off-by: Rui-Gan <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@Rui-Gan Rui-Gan marked this pull request as ready for review December 11, 2023 11:05
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LavenderQAQ,rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Dec 12, 2023
@rambohe-ch rambohe-ch merged commit 73315d2 into openyurtio:master Dec 12, 2023
14 of 15 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved do-not-merge/hold do-not-merge/hold lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants