Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message #1792

Merged
merged 2 commits into from
Nov 16, 2023
Merged

improve error message #1792

merged 2 commits into from
Nov 16, 2023

Conversation

dzcvxe
Copy link
Contributor

@dzcvxe dzcvxe commented Nov 13, 2023

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:
When unit tests failed, we need to search the keyword fail to find out the failed cases, but there are many error messages that include keyword fail, this will affect our efficiency in finding failed cases.

Which issue(s) this PR fixes:
Fixes #1781

@openyurt-bot
Copy link
Collaborator

Welcome @dzcvxe! It looks like this is your first PR to openyurtio/openyurt 🎉

@rambohe-ch
Copy link
Member

/rerun

@openyurt-bot openyurt-bot added the approved approved label Nov 14, 2023
@rambohe-ch
Copy link
Member

/rerun

@rambohe-ch
Copy link
Member

@dzcvxe Thank for very much, it is a good job.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rambohe-ch
Copy link
Member

/rerun

1 similar comment
@rambohe-ch
Copy link
Member

/rerun

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 363 lines in your changes are missing coverage. Please review.

Comparison is base (3636ec0) 52.23% compared to head (a9cc938) 52.23%.

Files Patch % Lines
pkg/yurthub/storage/disk/storage.go 0.00% 29 Missing ⚠️
pkg/yurthub/yurtcoordinator/coordinator.go 0.00% 26 Missing ⚠️
pkg/yurthub/cachemanager/cache_manager.go 31.42% 24 Missing ⚠️
...publicservice/gateway_public_service_controller.go 0.00% 14 Missing ⚠️
...troller/nodelifecycle/node_lifecycle_controller.go 0.00% 13 Missing ⚠️
pkg/yurttunnel/trafficforward/dns/dns.go 23.52% 13 Missing ⚠️
...n/gatewaypickup/gateway_pickup_enqueue_handlers.go 0.00% 12 Missing ⚠️
pkg/yurthub/storage/etcd/keycache.go 25.00% 9 Missing ⚠️
...yurthub/yurtcoordinator/certmanager/certmanager.go 10.00% 9 Missing ⚠️
pkg/yurttunnel/server/anpserver.go 0.00% 9 Missing ⚠️
... and 60 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1792   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files         172      172           
  Lines       20840    20840           
=======================================
  Hits        10885    10885           
  Misses       8998     8998           
  Partials      957      957           
Flag Coverage Δ
unittests 52.23% <7.86%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dzcvxe, rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YTGhost YTGhost merged commit 754ccf8 into openyurtio:master Nov 16, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] improve error message in order to up efficiency.
4 participants