Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pool scope crd resource etcd key path #1729

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

qsfang
Copy link
Contributor

@qsfang qsfang commented Oct 10, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

when pool scope resources set to some crd resources by editing yurt-hub-cfg configmap, the default etcd storage key is wrong, where resource group is not set in the key path

Which issue(s) this PR fixes:

Fixes #1728

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@qsfang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

when pool scope resources set to some crd resources by editing yurt-hub-cfg configmap, the default etcd storage key is wrong, where resource group is not set in the key path

Which issue(s) this PR fixes:

Fixes #1728

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

Welcome @qsfang! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1729 (ab1f653) into master (d89a805) will decrease coverage by 0.86%.
Report is 47 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
- Coverage   51.66%   50.81%   -0.86%     
==========================================
  Files         145      165      +20     
  Lines       17011    19254    +2243     
==========================================
+ Hits         8788     9783     +995     
- Misses       7407     8554    +1147     
- Partials      816      917     +101     
Flag Coverage Δ
unittests 50.81% <100.00%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/yurthub/storage/etcd/key.go 91.42% <100.00%> (+1.42%) ⬆️

... and 127 files with indirect coverage changes

@rambohe-ch
Copy link
Member

@qsfang please fix golangci-lint errors. package import should follow the following orders:

  • golang libs
  • k8s libs
  • openyurt libs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qsfang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Oct 11, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 11, 2023
@openyurt-bot openyurt-bot merged commit fbd5058 into openyurtio:master Oct 11, 2023
14 checks passed
@qsfang qsfang deleted the qsfang-dev branch October 11, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pool coordinator resource key path is wrong for extended custom resources
3 participants