-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pool scope crd resource etcd key path #1729
Conversation
@qsfang: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @qsfang! It looks like this is your first PR to openyurtio/openyurt 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
- Coverage 51.66% 50.81% -0.86%
==========================================
Files 145 165 +20
Lines 17011 19254 +2243
==========================================
+ Hits 8788 9783 +995
- Misses 7407 8554 +1147
- Partials 816 917 +101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@qsfang please fix golangci-lint errors. package import should follow the following orders:
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qsfang, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
when pool scope resources set to some crd resources by editing yurt-hub-cfg configmap, the default etcd storage key is wrong, where resource group is not set in the key path
Which issue(s) this PR fixes:
Fixes #1728
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note