-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support yurtadm config command #1709
Conversation
@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YTGhost The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
- Coverage 51.64% 51.61% -0.04%
==========================================
Files 168 169 +1
Lines 20063 20073 +10
==========================================
- Hits 10362 10360 -2
- Misses 8716 8727 +11
- Partials 985 986 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@rambohe-ch PTAL |
2ed9d51
to
3726345
Compare
Signed-off-by: Liang Deng <[email protected]>
3726345
to
df23e8c
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@rambohe-ch PTAL |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1536
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note