-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(yurt-iot-dock): temporarily remove v3 client to deal with code duplication #1686
refactor(yurt-iot-dock): temporarily remove v3 client to deal with code duplication #1686
Conversation
@LavenderQAQ: GitHub didn't allow me to assign the following users: your_reviewer, wangxye. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
329a7b9
to
abd60bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
- Coverage 51.64% 50.75% -0.89%
==========================================
Files 168 164 -4
Lines 20063 19238 -825
==========================================
- Hits 10362 9765 -597
+ Misses 8716 8555 -161
+ Partials 985 918 -67
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hold on, there are some problems with introducing packages. |
/hold |
abd60bd
to
3ecb55c
Compare
/unhold |
3ecb55c
to
4a2090f
Compare
12592a2
to
6e00a61
Compare
/assign |
/lgtm |
@wangxye: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LavenderQAQ, wangxye The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LavenderQAQ please fix the conflicting files. |
…de duplication Signed-off-by: LavenderQAQ <[email protected]>
6e00a61
to
02f914d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@rambohe-ch done. |
/lgtm |
/approve |
What type of PR is this?
/kind enhancement
/sig iot
What this PR does / why we need it:
For this pr, the client implementations of the yurt iot-dock of v2 and v3 are merged. Currently, the only difference between v2 and v3 clients is the api request path, which leads to a lot of code redundancy, so we won't separate them for now in 1.4. In 1.5 we will consider splitting them and bringing a MessageBus-based client implementation to v3.
Refer: #1680
Special notes for your reviewer:
/assign @rambohe-ch @wangxye