Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yurt-iot-dock): temporarily remove v3 client to deal with code duplication #1686

Merged

Conversation

LavenderQAQ
Copy link
Member

@LavenderQAQ LavenderQAQ commented Sep 1, 2023

What type of PR is this?

/kind enhancement
/sig iot

What this PR does / why we need it:

For this pr, the client implementations of the yurt iot-dock of v2 and v3 are merged. Currently, the only difference between v2 and v3 clients is the api request path, which leads to a lot of code redundancy, so we won't separate them for now in 1.4. In 1.5 we will consider splitting them and bringing a MessageBus-based client implementation to v3.
Refer: #1680

Special notes for your reviewer:

/assign @rambohe-ch @wangxye

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: GitHub didn't allow me to assign the following users: your_reviewer, wangxye.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement
/sig iot

What this PR does / why we need it:

For the time being, the client implementations of the yurt iot-dock of v2 and v3 are merged. Currently, the only difference between v2 and v3 clients is the api request path, which leads to a lot of code redundancy, so we won't separate them for now in 1.4. In 1.5 we will consider splitting them and bringing a MessageBus-based client implementation to v3.
Refer: #1680

Special notes for your reviewer:

/assign @rambohe-ch @wangxye

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the sig/iot sig/iot label Sep 1, 2023
@LavenderQAQ LavenderQAQ force-pushed the refactor/yurt-iot-dock-clients branch from 329a7b9 to abd60bd Compare September 1, 2023 03:07
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1686 (02f914d) into master (424dcc2) will decrease coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
- Coverage   51.64%   50.75%   -0.89%     
==========================================
  Files         168      164       -4     
  Lines       20063    19238     -825     
==========================================
- Hits        10362     9765     -597     
+ Misses       8716     8555     -161     
+ Partials      985      918      -67     
Flag Coverage Δ
unittests 50.75% <ø> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@LavenderQAQ
Copy link
Member Author

Hold on, there are some problems with introducing packages.

@LavenderQAQ
Copy link
Member Author

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Sep 1, 2023
@LavenderQAQ LavenderQAQ force-pushed the refactor/yurt-iot-dock-clients branch from abd60bd to 3ecb55c Compare September 1, 2023 07:54
@LavenderQAQ
Copy link
Member Author

/unhold

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label Sep 1, 2023
@LavenderQAQ LavenderQAQ force-pushed the refactor/yurt-iot-dock-clients branch from 3ecb55c to 4a2090f Compare September 1, 2023 08:09
@LavenderQAQ LavenderQAQ changed the title refactor(yurt-iot-dock): merge v2 and v3 client to deal with code duplication refactor(yurt-iot-dock): temporarily remove v3 client to deal with code duplication Sep 1, 2023
@LavenderQAQ LavenderQAQ force-pushed the refactor/yurt-iot-dock-clients branch 4 times, most recently from 12592a2 to 6e00a61 Compare September 1, 2023 09:26
@wangxye
Copy link
Member

wangxye commented Sep 2, 2023

/assign

@wangxye
Copy link
Member

wangxye commented Sep 2, 2023

/lgtm

@openyurt-bot
Copy link
Collaborator

@wangxye: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LavenderQAQ, wangxye
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

@LavenderQAQ please fix the conflicting files.

@LavenderQAQ LavenderQAQ force-pushed the refactor/yurt-iot-dock-clients branch from 6e00a61 to 02f914d Compare September 21, 2023 14:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LavenderQAQ
Copy link
Member Author

@rambohe-ch done.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 8, 2023
@rambohe-ch
Copy link
Member

/approve

@rambohe-ch rambohe-ch merged commit dd458e5 into openyurtio:master Oct 8, 2023
14 checks passed
@LavenderQAQ LavenderQAQ deleted the refactor/yurt-iot-dock-clients branch January 30, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants