Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposal of install openyurt components using dashboard #1664

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

401lrx
Copy link
Contributor

@401lrx 401lrx commented Aug 21, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add proposal of install openyurt components using dashboard

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
@luc99hen

Does this PR introduce a user-facing change?

@openyurt-bot openyurt-bot added the kind/documentation kind/documentation label Aug 21, 2023
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Aug 21, 2023
@openyurt-bot
Copy link
Collaborator

Welcome @401lrx! It looks like this is your first PR to openyurtio/openyurt 🎉


##### The first login screen for users

When visit the page for the first time after installing the dashboard, a guide page will be displayed. Check the components and click Next to complete the installation of the component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an UI preview here for this new login page?

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1664 (ce3ece9) into master (d15078f) will decrease coverage by 0.07%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   52.32%   52.25%   -0.07%     
==========================================
  Files         154      154              
  Lines       17637    17637              
==========================================
- Hits         9228     9216      -12     
- Misses       7582     7593      +11     
- Partials      827      828       +1     
Flag Coverage Δ
unittests 52.25% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@luc99hen
Copy link
Member

@rambohe-ch PTAL

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/approve

@rambohe-ch rambohe-ch merged commit 47f14df into openyurtio:master Aug 24, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 401lrx, luc99hen, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/documentation kind/documentation lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants