-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kubelet certificate mode in yurthub #1625
add kubelet certificate mode in yurthub #1625
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
31f05c4
to
bfa5aa6
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 51.43% 50.85% -0.58%
==========================================
Files 134 137 +3
Lines 15947 16029 +82
==========================================
- Hits 8202 8152 -50
- Misses 7000 7137 +137
+ Partials 745 740 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
add a new bootstrap mode:
kubeletcertificate
for yurthub component, so yurthub can use kubelet certificate to work.Which issue(s) this PR fixes:
Fixes #1618
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note