-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide users with the ability to customize the edgex framework #1596
feat: provide users with the ability to customize the edgex framework #1596
Conversation
@LavenderQAQ: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ae9f842
to
b9f9fe6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
- Coverage 51.43% 51.35% -0.08%
==========================================
Files 134 134
Lines 15947 15947
==========================================
- Hits 8202 8190 -12
- Misses 7000 7011 +11
- Partials 745 746 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
At present, the isolation of PlatformAdmin is not enough. It can only be configured on a namespace basis. When two edgex versions appear in a namespace, overwriting problems may occur. For this problem we need to combine #1435 to solve. |
b9f9fe6
to
204bdb1
Compare
/assign @Rui-Gan |
@LavenderQAQ: GitHub didn't allow me to assign the following users: Rui-Gan. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
204bdb1
to
b1ac0ac
Compare
Signed-off-by: LavenderQAQ <[email protected]>
b1ac0ac
to
dca9244
Compare
@Rui-Gan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: LavenderQAQ <[email protected]>
dca9244
to
9e8ae40
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/assign |
/lgtm |
@Rui-Gan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/sig iot
What this PR does / why we need it:
This pr will give users the ability to customize the edgex framework. We write the standard configuration collected by the auto-collector into a configmap called "platformadmin-framework". Users can customize their edgex by editing this configmap.
Which issue(s) this PR fixes:
Fixes #1595
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note