-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: added github registry #1578
Conversation
@siredmar: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @siredmar! It looks like this is your first PR to openyurtio/openyurt 🎉 |
@rambohe-ch you need to provide two repository secrets called |
@siredmar Very appreciate for your pull request. Because secrets are allowed start with |
@siredmar please fix the conflicting files. and the changes in this pull request should be merged into |
Signed-off-by: Armin Schlegel <[email protected]> wip
@rambohe-ch done |
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
=======================================
Coverage 51.43% 51.43%
=======================================
Files 134 134
Lines 15947 15947
=======================================
Hits 8202 8202
Misses 7000 7000
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, siredmar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Adds support for pushing to github container registry to avoid docker hub rate limits.
Which issue(s) this PR fixes:
Fixes #1575
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note