Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e test case for daemonset pod updater controller #1504

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

y-ykcir
Copy link
Member

@y-ykcir y-ykcir commented May 30, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1476

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

has written e2e tests for the auto upgrade model and ota upgrade model of the daemonset pod updater respectively

@openyurt-bot
Copy link
Collaborator

@y-ykcir: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1476

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

has written e2e tests for the auto upgrade model and ota upgrade model of the daemonset pod updater respectively

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot requested review from yixingjia and zzguang May 30, 2023 10:31
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1504 (77aa61e) into master (1822d27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1504   +/-   ##
=======================================
  Coverage   50.74%   50.74%           
=======================================
  Files         131      131           
  Lines       15576    15576           
=======================================
  Hits         7904     7904           
  Misses       6951     6951           
  Partials      721      721           
Flag Coverage Δ
unittests 50.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@y-ykcir y-ykcir force-pushed the feat-daemonupdater-e2e branch from 887d917 to c5ce7c6 Compare May 30, 2023 10:52
@y-ykcir
Copy link
Member Author

y-ykcir commented May 30, 2023

need to figure out the reason for autonomy test failure. It may be due to the use of the docker network disconnect/connect kind openyurt-e2e-test-worker2 in the daemonset pod updater test

@rambohe-ch
Copy link
Member

@xavier-hou PTAL

@xavier-hou
Copy link
Member

image

It seems that in Kind env, docker diconnect will effect flannel NIC. And this leds to the failure of autonomy e2e test.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@y-ykcir
Copy link
Member Author

y-ykcir commented Jun 2, 2023

@xavier-hou Has fixed the automony test according to the suggestions. PTAL.

@xavier-hou
Copy link
Member

@rambohe-ch LGTM

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, y-ykcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 2, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Jun 2, 2023
@openyurt-bot openyurt-bot merged commit b99c905 into openyurtio:master Jun 2, 2023
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request Jun 9, 2023
…tio#1504)

* feat: add e2e test case for daemonset pod updater controller

Signed-off-by: ricky <[email protected]>

* fix: automony failure

Signed-off-by: ricky <[email protected]>

---------

Signed-off-by: ricky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]add e2e test case for daemonset pod updater controller
4 participants