Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve yurtstaticset template metadata #1486

Merged

Conversation

JameKeal
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

If user defines different namespace in pod template with yurtstaticset namespace, yurtstaticset controller don't know how to handle this case.

Which issue(s) this PR fixes:

Fixes #1473

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

If user defines different namespace in pod template with yurtstaticset namespace, yurtstaticset controller don't know how to handle this case.

Which issue(s) this PR fixes:

Fixes #1473

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label May 23, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label May 23, 2023
@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Jun 5, 2023
@JameKeal JameKeal force-pushed the improve-yurtstaticset-template branch from 9d3c53c to c2e5152 Compare June 5, 2023 02:49
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1486 (9d3c53c) into master (b3ae2c7) will not change coverage.
The diff coverage is n/a.

❗ Current head 9d3c53c differs from pull request most recent head 87772d9. Consider uploading reports for the commit 87772d9 to get more accurate results

@@           Coverage Diff           @@
##           master    #1486   +/-   ##
=======================================
  Coverage   50.74%   50.74%           
=======================================
  Files         131      131           
  Lines       15576    15576           
=======================================
  Hits         7904     7904           
  Misses       6951     6951           
  Partials      721      721           
Flag Coverage Δ
unittests 50.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@openyurt-bot openyurt-bot removed the size/S size/S 10-29 label Jun 5, 2023
@JameKeal JameKeal force-pushed the improve-yurtstaticset-template branch from b3e1e90 to 87772d9 Compare June 5, 2023 06:52
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jun 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.8% 4.8% Duplication

@JameKeal JameKeal requested a review from rambohe-ch June 5, 2023 06:56
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 5, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jun 5, 2023
@openyurt-bot openyurt-bot merged commit 61f5299 into openyurtio:master Jun 5, 2023
@JameKeal JameKeal deleted the improve-yurtstaticset-template branch June 5, 2023 09:06
JameKeal added a commit to JameKeal/openyurt that referenced this pull request Jun 9, 2023
@rambohe-ch rambohe-ch added the backport release-v1.3 backport release-v1.3 label Jul 7, 2023
@rambohe-ch
Copy link
Member

/backport release-v1.3

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Successfully created backport PR for release-v1.3:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.3 backport release-v1.3 kind/feature kind/feature lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve yurtstaticset template metadata
4 participants