-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Yurtappdaemon e2e test #1406
Conversation
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
@theonefx: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
=======================================
Coverage 51.05% 51.05%
=======================================
Files 132 132
Lines 15568 15568
=======================================
Hits 7949 7949
Misses 6895 6895
Partials 724 724
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@theonefx how about add a test case that workloads will be removed automatically when nodepool is removed? |
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
done |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, theonefx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
add Yurtappdaemon e2e test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1396
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note