Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid doc link #1405

Merged
merged 6 commits into from
Apr 23, 2023
Merged

invalid doc link #1405

merged 6 commits into from
Apr 23, 2023

Conversation

lilongfeng0902
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation

What this PR does / why we need it:

yurt-app-manager repository does not exist, it has been added openyurt repository.

Which issue(s) this PR fixes:

Fixes #
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?


NONE

other Note

NONE

@openyurt-bot
Copy link
Collaborator

@lilongfeng0902: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation

What this PR does / why we need it:

yurt-app-manager repository does not exist, it has been added openyurt repository.

Which issue(s) this PR fixes:

Fixes #
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?


NONE

other Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/documentation kind/documentation label Apr 21, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Apr 21, 2023
@lilongfeng0902
Copy link
Member Author

/assign @Fei-Guo

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1405 (c00b1bd) into master (c08779f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1405   +/-   ##
=======================================
  Coverage   51.05%   51.05%           
=======================================
  Files         132      132           
  Lines       15568    15568           
=======================================
  Hits         7949     7949           
  Misses       6895     6895           
  Partials      724      724           
Flag Coverage Δ
unittests 51.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@lilongfeng0902 I think we can remove cmd/yurt-app-manager in OpenYurt. would you like to update this pr?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lilongfeng0902
Copy link
Member Author

@lilongfeng0902 I think we can remove cmd/yurt-app-manager in OpenYurt. would you like to update this pr?

I have removed cmd/yurt-app-manager in OpenYurt. Please review again, thanks.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilongfeng0902, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/documentation kind/documentation lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants