fix: set default podspec for staticpod podtemplatespec

[y-ykcir]

What type of PR is this?

/kind bug

What this PR does / why we need it:

If not set default PodSpec for staticpod PodTemplateSpec, then when applying staticpod, it may be rejected due to PodTemplateSpec validation not passing.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

[openyurt-bot]

@y-ykcir: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

If not set default PodSpec for staticpod PodTemplateSpec, then when applying staticpod, it may be rejected due to PodTemplateSpec validation not passing.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
3.7% Duplication

[codecov]

Codecov Report

Merging #1404 (a636707) into master (a65b31c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1404   +/-   ##
=======================================
  Coverage   51.05%   51.05%           
=======================================
  Files         132      132           
  Lines       15568    15568           
=======================================
  Hits         7949     7949           
  Misses       6895     6895           
  Partials      724      724           

Flag	Coverage Δ
unittests	51.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[xavier-hou]

@y-ykcir Would you explain more about this case? From my point, I think we do need to set the PodSpec in order to pass the validation. When will we need staticpod just have metav1.ObjectMeta~?

[y-ykcir]

@xavier-hou When I apply yurthub-staticpod.yaml. The following validation error occurred:

The StaticPod "yurt-hub" is invalid:
* template.spec.containers[0].livenessProbe.httpGet.scheme: Unsupported value: "": supported values: "HTTP", "HTTPS"
* template.spec.containers[0].livenessProbe.successThreshold: Invalid value: 0: must be 1
* template.spec.containers[0].terminationMessagePolicy: Required value: must be 'File' or 'FallbackToLogsOnError'
* template.spec.containers[0].env[0].valueFrom.fieldRef.apiVersion: Required value
* template.spec.restartPolicy: Required value
* template.spec.dnsPolicy: Required value

This should be because the validation requirement here is a complete template, and users may not always add default values when writing yaml. Therefore, it may be appropriate to add default values to fields that the user did not fill in during the mutate phase

[xavier-hou]

@y-ykcir Really appreciate for your information~

[openyurt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, y-ykcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rambohe-ch]

/lgtm