Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support yurthub component work in specified namespace #1366

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

huweihuang
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

What would you like to be added:
yurthub component should be deployed in kube-system namespace. as you known, kube-system namespace is used for K8s components, so some users have requested that yurthub can be deployed in specified namespace.

Why is this needed:
improve the deployment flexibility of OpenYurt component.

Which issue(s) this PR fixes:

Fixes # #1341

Does this PR introduce a user-facing change?

add a parameter for yurthub to specify namespace variable.

and update the yurthub.yaml namespace as specify namespace

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Apr 13, 2023
@huweihuang huweihuang force-pushed the feat/set-yurthub-namespace branch from e410c19 to b11e172 Compare April 13, 2023 03:21
@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Apr 13, 2023
@huweihuang
Copy link
Contributor Author

huweihuang commented Apr 13, 2023

@rambohe-ch please help to review it.

@huweihuang huweihuang force-pushed the feat/set-yurthub-namespace branch from b11e172 to 6427cc7 Compare April 13, 2023 06:26
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1366 (2c16022) into master (228240a) will increase coverage by 0.01%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
+ Coverage   52.13%   52.15%   +0.01%     
==========================================
  Files         107      107              
  Lines       13462    13466       +4     
==========================================
+ Hits         7019     7023       +4     
  Misses       5853     5853              
  Partials      590      590              
Flag Coverage Δ
unittests 52.15% <64.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/yurthub/app/config/config.go 53.61% <50.00%> (+0.35%) ⬆️
cmd/yurthub/app/options/options.go 94.73% <100.00%> (+0.06%) ⬆️
...yurthub/poolcoordinator/certmanager/certmanager.go 75.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

constants.PoolCoordinatorClientSecretNamespace should be replaced with options.YurtHubNamespace, because yurthub use this ns to get secret from cloud kube-apiserver.

@huweihuang huweihuang force-pushed the feat/set-yurthub-namespace branch from ba1dd5a to 0749cd9 Compare April 13, 2023 10:09
@huweihuang huweihuang force-pushed the feat/set-yurthub-namespace branch from 0766de0 to 324e543 Compare April 13, 2023 10:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huweihuang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants