-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support yurthub component work in specified namespace #1366
support yurthub component work in specified namespace #1366
Conversation
e410c19
to
b11e172
Compare
@rambohe-ch please help to review it. |
b11e172
to
6427cc7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1366 +/- ##
==========================================
+ Coverage 52.13% 52.15% +0.01%
==========================================
Files 107 107
Lines 13462 13466 +4
==========================================
+ Hits 7019 7023 +4
Misses 5853 5853
Partials 590 590
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
ba1dd5a
to
0749cd9
Compare
0766de0
to
324e543
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huweihuang, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
What would you like to be added:
yurthub component should be deployed in kube-system namespace. as you known, kube-system namespace is used for K8s components, so some users have requested that yurthub can be deployed in specified namespace.
Why is this needed:
improve the deployment flexibility of OpenYurt component.
Which issue(s) this PR fixes:
Fixes # #1341
Does this PR introduce a user-facing change?
add a parameter for yurthub to specify namespace variable.
and update the yurthub.yaml namespace as specify namespace