-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor pool-coordinator-cert controller #1364
refactor pool-coordinator-cert controller #1364
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@luc99hen PTAL |
1db3a2d
to
0581431
Compare
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 52.86% 52.59% -0.27%
==========================================
Files 103 103
Lines 12928 12989 +61
==========================================
- Hits 6834 6832 -2
- Misses 5537 5599 +62
- Partials 557 558 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0581431
to
f27e19d
Compare
f27e19d
to
0c1fc84
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
background:
pool coordinator cert controller is used for preparing certificates for pool coordinator component, and it should wait for service of pool-coordinator ready before creating certificates. At present, all certificates preparation is handled in controller setup, so other controllers setup are blocked by pool coordinator cert controller.
solution:
separate
allSelfSignedCerts
into three kinds:allIndependentCerts
: don't depend on service, and can be prepared in controller setup phase.certsDependOnAPIServerSvc
: depend on apiserver service, and should be prepared in controller reconcilecertsDependOnETCDSvc
: depend on etcd service, and should be prepared in controller reconcileWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note