feat: support pool-coordinator component work in specified namespace #1355
Conversation
|
You have successfully added a new Trivy configuration |
|
You have successfully added a new Trivy configuration |
|
You have successfully added a new Trivy configuration |
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
- Coverage 52.86% 52.85% -0.01%
==========================================
Files 103 103
Lines 12924 12929 +5
==========================================
+ Hits 6832 6834 +2
- Misses 5534 5538 +4
+ Partials 558 557 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| kind: Service | |||
| metadata: | |||
| name: pool-coordinator-apiserver | |||
| namespace: {{ .Release.Namespace | quote }} | |||
| namespace: {{ .Values.poolCoordinator.namespace | quote }} | |||
There was a problem hiding this comment.
I think the target is all components will be installed in the same namespace, so it is convenient to use .Release.Namespace to specify namespace for all components, and we don't need a unique namespace for each component.
Signed-off-by: ricky <[email protected]>
y-ykcir
force-pushed
the
deploy-poolcoordinator
branch
from
ea92eb3
to
b2cae85
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, y-ykcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rambohe-ch The completion of the poolcoordinator should also require synchronization changes in the yurthub like here, which may have to be done in the #1341 |
@y-ykcir yes, i think @huweihuang will handle it. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1342
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
add a parameter for yurt-manager to specify namespace variable for PoolcoordinatorNS
modified helm: use value to specify namespace in pool-coordinator.yaml and add startup parameter in yurt-manager.yaml