Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: yurthub automatically recognize nftables or iptables (#1135)" #1354

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

rambohe-ch
Copy link
Member

Reverts #1327

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/L size/L: 100-499 labels Apr 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurthub. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:node-servant. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurt-manager. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1354 (176c80b) into master (49219cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1354   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files         103      103           
  Lines       12924    12924           
=======================================
  Hits         6834     6834           
  Misses       5533     5533           
  Partials      557      557           
Flag Coverage Δ
unittests 52.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kadisi
Copy link
Member

kadisi commented Apr 3, 2023

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 3, 2023
@openyurt-bot openyurt-bot merged commit 1802826 into master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants