Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【FIX】fix yurt-controller-manager clusterrole missing pod delete #1338

Conversation

JameKeal
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

When i use daemonset auto updating, yurt-controller-manager have error, update failed.

I0328 09:04:36.175128   56436 daemon_pod_updater_controller.go:468] Auto update pod kube-keepalived-vip-ynp-g584f/kube-keepalived-vip-ynp-g584f-ppgbp
I0328 09:04:36.175177   56436 daemon_pod_updater_controller.go:240] error syncing event cattle-keepalived/kube-keepalived-vip-ynp-g584f: unable to delete pods: pods "kube-keepalived-vip-ynp-g584f-ppgbp" is forbidden: User "system:serviceaccount:kube-system:yurt-controller-manager" cannot delete resource "pods" in API group "" in the namespace "cattle-keepalived"

yurt-controller-manager don`t have pods delete permission.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

When i use daemonset auto updating, yurt-controller-manager have error, update failed.

I0328 09:04:36.175128   56436 daemon_pod_updater_controller.go:468] Auto update pod kube-keepalived-vip-ynp-g584f/kube-keepalived-vip-ynp-g584f-ppgbp
I0328 09:04:36.175177   56436 daemon_pod_updater_controller.go:240] error syncing event cattle-keepalived/kube-keepalived-vip-ynp-g584f: unable to delete pods: pods "kube-keepalived-vip-ynp-g584f-ppgbp" is forbidden: User "system:serviceaccount:kube-system:yurt-controller-manager" cannot delete resource "pods" in API group "" in the namespace "cattle-keepalived"

yurt-controller-manager don`t have pods delete permission.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Mar 29, 2023
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:node-servant. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurthub. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurt-manager. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1338 (2c98076) into master (3ee1eff) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   53.01%   53.08%   +0.07%     
==========================================
  Files         102      102              
  Lines       12833    12833              
==========================================
+ Hits         6803     6813      +10     
+ Misses       5472     5462      -10     
  Partials      558      558              
Flag Coverage Δ
unittests 53.08% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Mar 29, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 5b4cfd8 into openyurtio:master Mar 29, 2023
@JameKeal JameKeal deleted the fix-yurt-controller-manager-delete-pod branch March 29, 2023 06:37
JameKeal added a commit to JameKeal/openyurt that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants