Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yurt-controller-manager reboot cannot remove taint node.openyurt.io/unschedulable (#1233) #1337

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

AndyEWang
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

The taint node.openyurt.io/unschedulable can not be removed after the failure node recovers during yurt-controller-manager reboot.

Which issue(s) this PR fixes:

Fixes #1233

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Mar 29, 2023
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:node-servant. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurt-manager. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurthub. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@openyurt-bot openyurt-bot requested review from YTGhost and zzguang March 29, 2023 02:26
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1337 (162bb1c) into master (3ee1eff) will increase coverage by 0.08%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
+ Coverage   53.01%   53.10%   +0.08%     
==========================================
  Files         102      102              
  Lines       12833    12838       +5     
==========================================
+ Hits         6803     6817      +14     
+ Misses       5472     5464       -8     
+ Partials      558      557       -1     
Flag Coverage Δ
unittests 53.10% <33.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...inator/delegatelease/poolcoordinator_controller.go 38.29% <33.33%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyEWang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Mar 29, 2023
@openyurt-bot openyurt-bot merged commit 0896832 into openyurtio:master Mar 29, 2023
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
3 participants