-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【FIX】fix yurthub dnsPolicy when using pool-coordinator #1321
Conversation
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You have successfully added a new Trivy configuration |
You have successfully added a new Trivy configuration |
You have successfully added a new Trivy configuration |
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
- Coverage 53.28% 52.97% -0.32%
==========================================
Files 102 103 +1
Lines 12776 12924 +148
==========================================
+ Hits 6808 6846 +38
- Misses 5413 5520 +107
- Partials 555 558 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold We should figure out why e2e tests failed. @JameKeal Could you please use command |
…rdinator from domain to service ip
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@Congrool PTAL |
/unhold Thanks for your contribution! It's ready for merge I think. @rambohe-ch |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
YurtHub not set dnsPolicy, it use ClusterFirst in default, but it set hostNetwork=true, dnsPolicy turns into None, it`s means yurtHub only the resolution configured in dnsConfig is used, cluster and node resolution is not used.
It`s error when yurthub use pool-coordinator by services.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@rambohe-ch
Does this PR introduce a user-facing change?
other Note