Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StaticPod CRD and controller #1261

Merged
merged 11 commits into from
Apr 13, 2023
Merged

Conversation

xavier-hou
Copy link
Member

@xavier-hou xavier-hou commented Feb 23, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1079

Related #1067

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1079

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1261 (ef97ba8) into master (4f62983) will decrease coverage by 0.18%.
The diff coverage is 46.44%.

@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
- Coverage   52.31%   52.13%   -0.18%     
==========================================
  Files         103      105       +2     
  Lines       12963    13357     +394     
==========================================
+ Hits         6781     6964     +183     
- Misses       5629     5810     +181     
- Partials      553      583      +30     
Flag Coverage Δ
unittests 52.13% <46.44%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/staticpod/staticpod_controller.go 43.08% <43.08%> (ø)
...g/controller/staticpod/upgradeinfo/upgrade_info.go 59.03% <59.03%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/controller/staticpod/staticpod_controller.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/staticpod_controller.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/staticpod_controller.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/staticpod_controller.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/staticpod_controller.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/staticpod_controller.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/util/util.go Outdated Show resolved Hide resolved
pkg/controller/staticpod/util/util.go Outdated Show resolved Hide resolved
pkg/webhook/staticpod/validating/staticpod_handler.go Outdated Show resolved Hide resolved
@rambohe-ch
Copy link
Member

@xavier-hou please rebase upstream/master to fix conflicting files.

@xavier-hou xavier-hou force-pushed the static-pod branch 2 times, most recently from 6ffddbf to d1c63d7 Compare March 24, 2023 23:12
@xavier-hou xavier-hou requested review from rambohe-ch and removed request for Congrool March 26, 2023 04:48
@rambohe-ch
Copy link
Member

@xavier-hou please fix the conflicting files.

@@ -824,7 +1029,7 @@ webhooks:
name: validate.core.v1.pod.openyurt.io
rules:
- apiGroups:
- ""
- core.openyurt.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the group of pod is "" instead of core.openyurt.io

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: hxcGit <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Apr 13, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 13, 2023
@openyurt-bot openyurt-bot merged commit 228240a into openyurtio:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]support OTA and Auto upgrade model for static pod
4 participants