-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add StaticPod CRD and controller #1261
Conversation
@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
==========================================
- Coverage 52.31% 52.13% -0.18%
==========================================
Files 103 105 +2
Lines 12963 13357 +394
==========================================
+ Hits 6781 6964 +183
- Misses 5629 5810 +181
- Partials 553 583 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
65d157c
to
3715b52
Compare
@xavier-hou please rebase upstream/master to fix conflicting files. |
6ffddbf
to
d1c63d7
Compare
@xavier-hou please fix the conflicting files. |
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
@@ -824,7 +1029,7 @@ webhooks: | |||
name: validate.core.v1.pod.openyurt.io | |||
rules: | |||
- apiGroups: | |||
- "" | |||
- core.openyurt.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the group of pod is "" instead of core.openyurt.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: hxcGit <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, xavier-hou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1079
Related #1067
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note