Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fengshunli as reviewers of OpenYurt #1257

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

fengshunli
Copy link
Member

@fengshunli fengshunli commented Feb 23, 2023

GitHub Username

@fengshunli

Organization you are requesting membership in

openyurtio

Sponsors

@rambohe-ch

Requirements

  • I have joined in the community Dingding and [WeChat]
  • I often attend Openyurt Community Week
  • I have reviewed the [community membership docs]
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
  • I have checked my affiliation in devstats (if it's not correct, please fix in cncf/gitdm)
  • I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

Brief Introduction

@openyurt-bot
Copy link
Collaborator

@fengshunli: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1257 (8276e52) into master (d4f1f3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1257   +/-   ##
=======================================
  Coverage   53.62%   53.62%           
=======================================
  Files         102      102           
  Lines       12751    12751           
=======================================
  Hits         6838     6838           
  Misses       5359     5359           
  Partials      554      554           
Flag Coverage Δ
unittests 53.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@fengshunli Thanks your contributions to OpenYurt. agree +1

@Congrool
Copy link
Member

agree +1

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengshunli, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot removed the lgtm lgtm label Feb 24, 2023
@openyurt-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@openyurt-bot openyurt-bot merged commit 4650fa8 into openyurtio:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants