-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] improve image build efficiency #1191
Conversation
@Congrool: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
=======================================
Coverage 52.16% 52.16%
=======================================
Files 110 110
Lines 13848 13848
=======================================
Hits 7224 7224
Misses 5977 5977
Partials 647 647
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The time of the build-image step in e2e-tests can be reduced from orginal 6m-9m to current 2m30s. |
/hold |
4e60aaf
to
0f20649
Compare
Signed-off-by: Congrool <[email protected]>
/unhold |
@Congrool It's good job to improve image build efficiency, and cost time of e2e-tests has reduced from 25m to 17m. but |
Signed-off-by: Congrool <[email protected]>
/hold cancel |
This current improvement is only useful for build images, but not suitable for relasing images which is cross-platform. Thus, we still use the original dockerfile to release images. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Congrool When I use When testing locally, most of dependency libraries have been downloaded to local machine in advance, which will reduce the time it takes to execute |
Signed-off-by: Congrool [email protected]
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Currently, if we build all images, it has to download dependent go package for several times, which makes the build too slow.
In this pr, we will start a container
openyurt-build
which will build all binaries first, and then using these built binaries to build images.Also, we can still only build one of these image as we need. For example:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note