Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app to support upgrade static pod #1168

Merged
merged 12 commits into from
Apr 13, 2023

Conversation

xavier-hou
Copy link
Member

@xavier-hou xavier-hou commented Jan 19, 2023

Signed-off-by: hxcGit [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Relate to: #1079

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: hxcGit [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1168 (6346766) into master (1802826) will decrease coverage by 0.56%.
The diff coverage is 53.92%.

@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
- Coverage   52.87%   52.32%   -0.56%     
==========================================
  Files         103      105       +2     
  Lines       12924    13065     +141     
==========================================
+ Hits         6834     6836       +2     
- Misses       5533     5669     +136     
- Partials      557      560       +3     
Flag Coverage Δ
unittests 52.32% <53.92%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/node-servant/static-pod-upgrade/options.go 0.00% <0.00%> (ø)
pkg/node-servant/static-pod-upgrade/upgrade.go 64.70% <64.70%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xavier-hou xavier-hou force-pushed the static-pod-upgrade branch 2 times, most recently from 991255b to faed9ea Compare March 24, 2023 23:21
@openyurt-bot openyurt-bot added size/L size/L: 100-499 and removed size/XL size/XL: 500-999 labels Mar 24, 2023
@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Apr 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Apr 13, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 13, 2023
@openyurt-bot openyurt-bot merged commit 33da495 into openyurtio:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants