make yurt-controller-manager take care of webhook configurations and … #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunu
force-pushed
the
webhook-self-sign
branch
from
6a115b8 to
d2475de
Compare
gnunu
force-pushed
the
webhook-self-sign
branch
from
d2475de to
1a8c885
Compare
rambohe-ch
approved these changes
Jan 4, 2023
|
@gnunu please fix the conflicting file. |
gnunu
force-pushed
the
webhook-self-sign
branch
from
1a8c885 to
2bde1c0
Compare
rambohe-ch
approved these changes
Jan 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnunu, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…certs
What type of PR is this?
What this PR does / why we need it:
When yurt-controller-manager introduced pod webhook for create/update, the webhook configuration including ca/certs should be provisioned with the yurt-controller-manager pod as an atomic operation. Thus, the webhook configurations' creation/update and ca and certs would be taken care of by yurt-controller-manager itself. So this PR does these:
Which issue(s) this PR fixes:
Fixes #1040
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note