-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve e2e tests for supporting mac env and coredns autonomy #1045
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Congrool @lorrielau PTAL |
4e35553
to
88e5ac8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
+ Coverage 49.24% 49.47% +0.22%
==========================================
Files 96 96
Lines 13022 13054 +32
==========================================
+ Hits 6413 6458 +45
+ Misses 6078 6060 -18
- Partials 531 536 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It seems that 10s timeout is too short for recovering coredns. We can change it to 30s. |
88e5ac8
to
a93c21d
Compare
@Congrool Thanks for your feedback, i have revised the timeout duration to 30s. |
a93c21d
to
e5b929c
Compare
e5b929c
to
cfba660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixes #1037 |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
improve e2e tests as following:
ENABLE_AUTONOMY_TESTS
for enabling or disabling autonomy e2e tests, default is: true(enable autonomy e2e tests)TARGET_PLATFORMS
for specifying platform that run e2e tests. for example: the command for running e2e tests on mac env: make e2e-tests TARGET_PLATFORMS=linux/arm64Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note