Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve e2e tests for supporting mac env and coredns autonomy #1045

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

improve e2e tests as following:

  1. add a parameter ENABLE_AUTONOMY_TESTS for enabling or disabling autonomy e2e tests, default is: true(enable autonomy e2e tests)
  2. add a parameter TARGET_PLATFORMS for specifying platform that run e2e tests. for example: the command for running e2e tests on mac env: make e2e-tests TARGET_PLATFORMS=linux/arm64
  3. enable autonomy tests for CoreDNS component.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

improve e2e tests as following:

  1. add a parameter ENABLE_AUTONOMY_TESTS for enabling or disabling autonomy e2e tests, default is: true(enable autonomy e2e tests)
  2. add a parameter TARGET_PLATFORMS for specifying platform that run e2e tests. for example: the command for running e2e tests on mac env: make e2e-tests TARGET_PLATFORMS=linux/arm64
  3. enable autonomy tests for CoreDNS component.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Nov 1, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/L size/L: 100-499 labels Nov 1, 2022
@rambohe-ch
Copy link
Member Author

@Congrool @lorrielau PTAL

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1045 (cfba660) into master (5dc6738) will increase coverage by 0.22%.
The diff coverage is 48.48%.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   49.24%   49.47%   +0.22%     
==========================================
  Files          96       96              
  Lines       13022    13054      +32     
==========================================
+ Hits         6413     6458      +45     
+ Misses       6078     6060      -18     
- Partials      531      536       +5     
Flag Coverage Δ
unittests 49.47% <48.48%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurtctl/cmd/yurttest/kindinit/init.go 57.11% <48.48%> (+6.01%) ⬆️
pkg/util/iptables/iptables.go 87.67% <0.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Congrool
Copy link
Member

Congrool commented Nov 2, 2022

It seems that 10s timeout is too short for recovering coredns. We can change it to 30s.

@rambohe-ch
Copy link
Member Author

It seems that 10s timeout is too short for recovering coredns. We can change it to 30s.

@Congrool Thanks for your feedback, i have revised the timeout duration to 30s.

test/e2e/autonomy/autonomy_test.go Outdated Show resolved Hide resolved
test/e2e/autonomy/autonomy_test.go Outdated Show resolved Hide resolved
Copy link
Member

@Congrool Congrool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 2, 2022
@openyurt-bot openyurt-bot merged commit 14be3b5 into openyurtio:master Nov 2, 2022
@rambohe-ch
Copy link
Member Author

Fixes #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants