Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add yurthub leader election and coordinator framework #1035

Merged
merged 2 commits into from
Nov 10, 2022
Merged

add yurthub leader election and coordinator framework #1035

merged 2 commits into from
Nov 10, 2022

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch force-pushed the pool-coordinator-dev branch from 06e3154 to f1c3a21 Compare October 25, 2022 08:13
@Congrool
Copy link
Member

LGTM, and I'll implement the pool-coordinator based on this pr.

Congrool
Congrool reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@Congrool Congrool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 10, 2022
@openyurt-bot openyurt-bot merged commit f87a711 into openyurtio:pool-coordinator-dev Nov 10, 2022
@rambohe-ch
Copy link
Member Author

Fixes #779

@rambohe-ch rambohe-ch linked an issue Nov 15, 2022 that may be closed by this pull request
[feature request] NodePool Governance Capability: yurthub are delegated to report heartbeats for nodes that disconnected with cloud #779
Closed
rambohe-ch added a commit that referenced this pull request Nov 21, 2022
@rambohe-ch
add yurthub leader election and coordinator framework (#1035)
3a15a1d 
* improve health checker for adapting coordinator

* add yurthub leader election and coordinator framework
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Nov 22, 2022
@rambohe-ch
add yurthub leader election and coordinator framework (openyurtio#1035)
adbf572 
* improve health checker for adapting coordinator

* add yurthub leader election and coordinator framework
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Nov 22, 2022
@rambohe-ch @Congrool
add yurthub leader election and coordinator framework (openyurtio#1035)
54b5127 
* improve health checker for adapting coordinator

* add yurthub leader election and coordinator framework

Signed-off-by: Congrool <[email protected]>
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Nov 22, 2022
@rambohe-ch @Congrool
add yurthub leader election and coordinator framework (openyurtio#1035)
998f409 
* improve health checker for adapting coordinator

* add yurthub leader election and coordinator framework
rambohe-ch added a commit that referenced this pull request Nov 23, 2022
@rambohe-ch
add yurthub leader election and coordinator framework (#1035)
0db2b87 
* improve health checker for adapting coordinator

* add yurthub leader election and coordinator framework
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Jan 17, 2023
@rambohe-ch @Congrool
add yurthub leader election and coordinator framework (openyurtio#1035)
16a399e 
* improve health checker for adapting coordinator

* add yurthub leader election and coordinator framework
@Congrool Congrool mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Congrool Congrool Congrool left review comments

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

Assignees

@Congrool Congrool

Labels
approved approved lgtm lgtm size/XXL
Projects
None yet
Milestone
No milestone
3 participants
@rambohe-ch @openyurt-bot @Congrool