Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposal to unify cloud edge comms solution #1027

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

zzguang
Copy link
Member

@zzguang zzguang commented Oct 11, 2022

Current OpenYurt provides 2 independent solutions in cloud edge comms domain, which are Raven and YurtTunnel, this proposal aims to integrate YurtTunnel into Raven, and provide an unified cloud edge comms solution to users.

Signed-off-by: zzguang [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@zzguang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Current OpenYurt provides 2 independent solutions in cloud edge comms domain, which are Raven and YurtTunnel, this proposal aims to integrate YurtTunnel into Raven, and provide an unified cloud edge comms solution to users.

Signed-off-by: zzguang [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1027 (56aaf28) into master (eb5f406) will increase coverage by 0.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   47.59%   48.15%   +0.56%     
==========================================
  Files          89       95       +6     
  Lines       12548    13010     +462     
==========================================
+ Hits         5972     6265     +293     
- Misses       6060     6209     +149     
- Partials      516      536      +20     
Flag Coverage Δ
unittests 48.15% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/filter/masterservice/handler.go 75.80% <0.00%> (-0.39%) ⬇️
pkg/yurthub/filter/filter.go 0.00% <0.00%> (ø)
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)
pkg/yurthub/filter/masterservice/filter.go 0.00% <0.00%> (ø)
pkg/yurthub/filter/servicetopology/filter.go 0.00% <0.00%> (ø)
pkg/yurthub/filter/discardcloudservice/filter.go 0.00% <0.00%> (ø)
pkg/yurthub/filter/manager.go
...servicetopology/adapter/endpointslicev1_adapter.go 81.81% <0.00%> (ø)
...oller/servicetopology/adapter/endpoints_adapter.go 88.23% <0.00%> (ø)
pkg/yurthub/filter/manager/manager.go 75.47% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@zzguang please fix misspell errors.

@rambohe-ch
Copy link
Member

@zzguang Thanks for posting pull request about integrating yurttunnel into raven. and i agree with you that yurttunnel and raven are independent solutions in cloud edge comms domain. but yurttunnel is a 7 layer solution for forwarding http/https requests from cloud to edge, and raven is a 3 layer solution for forwarding requests between cloud and edge, or edge to edge.

DevOps traffic and business data traffic can use these two solutions simultaneously in terms of their requirements. for example, DevOps traffic can use both yurttunnel and raven.

I think that the solution 4 is so complicated because end user should take care 4 components. how about integrate raven-gateway-agent and raven-tunnel-agent into one component?

@zzguang
Copy link
Member Author

zzguang commented Oct 11, 2022

@zzguang Thanks for posting pull request about integrating yurttunnel into raven. and i agree with you that yurttunnel and raven are independent solutions in cloud edge comms domain. but yurttunnel is a 7 layer solution for forwarding http/https requests from cloud to edge, and raven is a 3 layer solution for forwarding requests between cloud and edge, or edge to edge.

DevOps traffic and business data traffic can use these two solutions simultaneously in terms of their requirements. for example, DevOps traffic can use both yurttunnel and raven.

I think that the solution 4 is so complicated because end user should take care 4 components. how about integrate raven-gateway-agent and raven-tunnel-agent into one component?

Thanks for your comments, IMHO, since we can not merge the layer 7 yurttunnel completely into layer 3 raven, we should decouple them clearly for users. If we fuse them on edge side while keep them separated on cloud side, it may lead to confusions to users when they only want to adopt one of them.

@zzguang zzguang force-pushed the raven-tunnel branch 11 times, most recently from 1f56fe5 to 7916910 Compare October 18, 2022 12:37
Current OpenYurt provides 2 independent solutions in cross network domain
communication, which are Raven and YurtTunnel, it's hard to maintain from
the project management perspective, also it may lead to users confusions
on how to select them for their usage scenarios, this proposal aims to unify
these solutions to enhance the OpenYurt data plane.

Signed-off-by: zzguang <[email protected]>
@openyurt-bot openyurt-bot added the approved approved label Oct 20, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 20, 2022
@openyurt-bot openyurt-bot merged commit 2a67506 into openyurtio:master Oct 20, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants