Add released openyurt versions to projectInfo when building binaries #1016
Conversation
|
@Congrool: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We can build yurtctl and run |
@Congrool It's a good idea to detect and verify version of OpenYurt automatically. and one of my concerns is that |
|
@rambohe-ch Good idea, I'll do that. I think the number of valid openyurt versions should depend on how many versions we will keep maintain and do back-port. |
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
- Coverage 47.42% 47.40% -0.02%
==========================================
Files 85 85
Lines 11791 11791
==========================================
- Hits 5592 5590 -2
- Misses 5738 5739 +1
- Partials 461 462 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@Congrool I think maybe 3 or 4 versions is enough. |
|
Done. And currently I set the num as 3, which means, for example, v1.0.*, v0.7.* and v0.6.*. The linked versions looks like: PTAL @rambohe-ch |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
…penyurtio#1016) * add all versions to projectInfo * remove validOpenYurtVersions from yurtctl test
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
As #1007 , when we release new version of openyurt, we have to manually revise versions in code, which is often forgot. This pr will automatically detect released versions of openyurt and link to projectInfo when building binaries, which can simplify what we need to do when releasing new version.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note