Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Yurthub data filtering framework optimization #699

Closed
zzguang opened this issue Dec 28, 2021 · 4 comments · Fixed by #749
Closed

[feature request] Yurthub data filtering framework optimization #699

zzguang opened this issue Dec 28, 2021 · 4 comments · Fixed by #749
Assignees
Labels
kind/feature kind/feature

Comments

@zzguang
Copy link
Member

zzguang commented Dec 28, 2021

What would you like to be added:
Current yurthub data filtering framework has some limitations, such as:

  1. It hardcoded the components and the resources/verbs, which is not convenient to reuse the same resource filtering for different components.
  2. One component can only filter one resource, which can not meet the requirements for some components.
    So it seems the current implementation needs to be optimized to be a more generic way:
  3. Implement the different resources filtering in the core framework
  4. Define the components and resources/verbs map in a configurable way, e.g. configmap
  5. Implementing it through webhook may be another option

Why is this needed:

  1. One resource filtering can be reused by multiple components
  2. One component can filter multiple resources conveniently, especially for the components which needs to cache data locally by yurthub, filtering to cache the resources only it requires can reduce the storage burden of the Edge device.

others
/kind feature

@zzguang zzguang added the kind/feature kind/feature label Dec 28, 2021
@rambohe-ch
Copy link
Member

@zzguang Very appreciate for your consideration. components and verbs in filter are used by filter.Approve only, so it's a good idea to extract resource filters for sharing by multi components.

@rambohe-ch
Copy link
Member

@zzguang would you like to take over this feature?

@zzguang
Copy link
Member Author

zzguang commented Jan 17, 2022

@zzguang would you like to take over this feature?
@rambohe-ch I am not sure when I will have time to optimize it by now, we are making plan for 2022 and some important issues need to be figured out firstly, then we will define the priorities of them. If some others are interested in this feature, you can assign it to them, otherwise, I can take a look at it in future.

zzguang referenced this issue in zzguang/openyurt Jan 23, 2022
@yingjianjian
Copy link
Member

/assign @yingjianjian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants