Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zzguang as approver of OpenYurt #929

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add zzguang as approver of OpenYurt #929

merged 1 commit into from
Jul 26, 2022

Conversation

zzguang
Copy link
Member

@zzguang zzguang commented Jul 25, 2022

GitHub Username

@zzguang

Organization you are requesting membership in

openyurtio

Sponsors

@kadisi

Requirements

  • I have joined in the community [Dingding] and [WeChat]
  • I often attend Openyurt Community Week
  • I have reviewed the [community membership docs]
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
  • I have checked my affiliation in [devstats] (if it's not correct, please fix in [cncf/gitdm])
  • I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jul 25, 2022
@zzguang
Copy link
Member Author

zzguang commented Jul 25, 2022

/assign @rambohe-ch @kadisi

@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #929 (5a6495e) into master (2d5938d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #929   +/-   ##
=======================================
  Coverage   35.37%   35.37%           
=======================================
  Files          76       76           
  Lines        9913     9913           
=======================================
  Hits         3507     3507           
  Misses       6141     6141           
  Partials      265      265
Flag Coverage Δ
unittests 35.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rambohe-ch
Copy link
Member

@zzguang welcome you. agree+1

@kadisi
Copy link
Member

kadisi commented Jul 25, 2022

agree +1

@openyurt-bot openyurt-bot added the approved approved label Jul 26, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 26, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit bdcb53d into openyurtio:master Jul 26, 2022
lorrielau pushed a commit to lorrielau/openyurt that referenced this pull request Aug 10, 2022
@lorrielau
Add zzguang as approver of OpenYurt (openyurtio#929)
fdf8bbd 
Signed-off-by: zzguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

Assignees

@kadisi kadisi

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzguang @rambohe-ch @kadisi @openyurt-bot