Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tunnelAgentConnectPort to values #9

Conversation

huweihuang
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Since users generally need to modify tunnelAgentConnectPort, it is recommended to add it to values.yaml for customization

@huweihuang
Copy link
Author

@rambohe-ch

@rambohe-ch
Copy link
Member

@huweihuang Thank you for posting pull request. but it's not recommended to create pull request in this repo to update helm charts, because all helm charts in this repo are synced from other repos(like openyurtio/openyurt) automatically. in other word, this repo is only a place holder for all helm charts of OpenYurt.

so please make pull request for updating yurt-tunnel helm chart in openyurtio/openyurt repo: https://github.com/openyurtio/openyurt

@huweihuang
Copy link
Author

@rambohe-ch ok, i make pull request in openyurtio/openyurt#1114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants