Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add unit tests #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mowangdk
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

Add unit test

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@mowangdk: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

Add unit test

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Aug 29, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/XL size/XL: 500-999 labels Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #14 (27eaa26) into main (27ca36c) will decrease coverage by 7.39%.
The diff coverage is 100.00%.

❗ Current head 27eaa26 differs from pull request most recent head a33a23f. Consider uploading reports for the commit a33a23f to get more accurate results

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   23.47%   16.08%   -7.39%     
==========================================
  Files           4       11       +7     
  Lines         639     1374     +735     
==========================================
+ Hits          150      221      +71     
- Misses        462     1124     +662     
- Partials       27       29       +2     
Flag Coverage Δ
unittests 16.08% <100.00%> (-7.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/config/cloud.go 100.00% <100.00%> (ø)
pkg/utils/pmem.go 0.00% <0.00%> (ø)
pkg/utils/utils.go 19.49% <0.00%> (ø)
pkg/utils/lvm.go 0.00% <0.00%> (ø)
pkg/model/type.go 11.40% <0.00%> (ø)
pkg/err/errors.go 100.00% <0.00%> (ø)
pkg/utils/mounter.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mowangdk mowangdk force-pushed the chore/add_ut branch 2 times, most recently from 05b4edc to 43344d5 Compare August 29, 2022 02:57
@mowangdk
Copy link
Member Author

mowangdk commented Feb 2, 2023

/test

@mowangdk mowangdk force-pushed the chore/add_ut branch 2 times, most recently from c9bfaad to 27eaa26 Compare February 2, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement size/XL size/XL: 500-999
Projects
No open projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants