Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add more comprehensive error handling #5

Merged
merged 13 commits into from
Sep 18, 2023
Merged

[Feature] Add more comprehensive error handling #5

merged 13 commits into from
Sep 18, 2023

Conversation

HaiyiMei
Copy link
Collaborator

@HaiyiMei HaiyiMei commented Sep 11, 2023 •
edited
Loading

  • fix typo
  • add more assert to prevent improper input
  • add version control for plugins of XRFeitoriaBpy and XRFeitoriaUnreal
  • add a threading of checking if the engine is alive. If the engine dead detected, throw an error with engine output

yl-1993
yl-1993 reviewed Sep 14, 2023
View reviewed changes
xrfeitoria/utils/runner.py Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@HaiyiMei HaiyiMei changed the title [Fix] Bugs [Add] more comprehensive error handling Sep 16, 2023
@HaiyiMei
Copy link
Collaborator Author

@yl-1993 This PR is ready to be merged.

@HaiyiMei HaiyiMei added enhancement New feature or request bug Something isn't working labels Sep 17, 2023
@HaiyiMei HaiyiMei changed the title [Add] more comprehensive error handling [Feature] Add more comprehensive error handling Sep 18, 2023
@yl-1993 yl-1993 merged commit 8f13882 into main Sep 18, 2023
3 checks passed
@yl-1993 yl-1993 deleted the dev branch September 18, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yl-1993 yl-1993 yl-1993 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaiyiMei @CLAassistant @yl-1993