[XLA:GPU] Add profiler annotation for sequential thunk. #21134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
approved these changes
Jan 8, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 11, 2025
Imported from GitHub PR #21134 This PR wraps sequential thunk with profiler annotations, which will make loop iterations, and conditional branch more easy to read in the profiler. The nsys profile looks like this:  Copybara import of the project: -- eea74b8 by Shawn Wang <[email protected]>: add nvtx marker for sequential thunk Merging this change closes #21134 FUTURE_COPYBARA_INTEGRATE_REVIEW=#21134 from shawnwang18:shawnw/add_profiler_for_while_body_cond eea74b8 PiperOrigin-RevId: 713359421
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 11, 2025
Imported from GitHub PR openxla/xla#21134 This PR wraps sequential thunk with profiler annotations, which will make loop iterations, and conditional branch more easy to read in the profiler. The nsys profile looks like this:  Copybara import of the project: -- eea74b86f5e2b71c915553ec302e16645927e191 by Shawn Wang <[email protected]>: add nvtx marker for sequential thunk Merging this change closes #21134 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21134 from shawnwang18:shawnw/add_profiler_for_while_body_cond eea74b86f5e2b71c915553ec302e16645927e191 PiperOrigin-RevId: 713359421
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 11, 2025
Imported from GitHub PR openxla/xla#21134 This PR wraps sequential thunk with profiler annotations, which will make loop iterations, and conditional branch more easy to read in the profiler. The nsys profile looks like this:  Copybara import of the project: -- eea74b86f5e2b71c915553ec302e16645927e191 by Shawn Wang <[email protected]>: add nvtx marker for sequential thunk Merging this change closes #21134 PiperOrigin-RevId: 714296359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps sequential thunk with profiler annotations, which will make loop iterations, and conditional branch more easy to read in the profiler.
The nsys profile looks like this: