PR #18773: [ReduceScatterCombiner] Provide option to not combine within while loop bodies. #19139
+66
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_694004933
branch
5 times, most recently
from
00f33b9
to
1063fb5
Compare
…in while loop bodies. Imported from GitHub PR #18773 Same as #18772 but for reduce-scatters. Copying from #18772 This PR provides an option to disable combining reduce-scatters inside while loop bodies. It is set to true, so existing behavior is maintained. This option is provided as some strategies for FSDP may only want to coalesce collectives that are outside of a while loop. Collectives inside while loop are not coalesced, as we assume there is sufficient compute to overlap. Copybara import of the project: -- 9a7d247 by ptoulme-aws <[email protected]>: [ReduceScatterCombiner] Provide option to not combine within while loop bodies. Merging this change closes #18773 COPYBARA_INTEGRATE_REVIEW=#18773 from ptoulme-aws:reduce_scatter_combine_while 9a7d247 PiperOrigin-RevId: 694566690
copybara-service
bot
force-pushed
the
test_694004933
branch
from
1063fb5
to
22c2e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18773: [ReduceScatterCombiner] Provide option to not combine within while loop bodies.
Imported from GitHub PR #18773
Same as #18772 but for reduce-scatters. Copying from #18772
This PR provides an option to disable combining reduce-scatters inside while loop bodies.
It is set to true, so existing behavior is maintained.
This option is provided as some strategies for FSDP may only want to coalesce collectives that are outside of a while loop. Collectives inside while loop are not coalesced, as we assume there is sufficient compute to overlap.
Copybara import of the project:
--
9a7d247 by ptoulme-aws [email protected]:
[ReduceScatterCombiner] Provide option to not combine within while loop bodies.
Merging this change closes #18773
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18773 from ptoulme-aws:reduce_scatter_combine_while 9a7d247