New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally don't inline stream annotated kCalls #18448

Closed

chaserileyroberts wants to merge 1 commit into openxla:main from chaserileyroberts:chase/stream_call_noinline

+81 −2

Contributor

chaserileyroberts commented Oct 17, 2024

First part of splitting up #17982

chaserileyroberts requested a review from golechwierowicz

October 17, 2024 17:33

golechwierowicz requested a review from frgossen

October 18, 2024 08:36

golechwierowicz reviewed

View reviewed changes

Member

golechwierowicz left a comment

Thank you for the PR split! Much appreciated!

xla/service/call_inliner_test.cc Outdated Show resolved Hide resolved

chaserileyroberts force-pushed the chase/stream_call_noinline branch 2 times, most recently from 78cf7aa to 5ac671a Compare

October 24, 2024 17:36

Contributor Author

chaserileyroberts commented Oct 24, 2024

I've updated the test.

sanjoy reviewed

View reviewed changes

Contributor

sanjoy left a comment

Left some minor nitpicky comments inline.

xla/service/call_inliner.cc Outdated Show resolved Hide resolved

xla/xla.proto Outdated Show resolved Hide resolved


          Don't inline stream annotated kCalls

8ecc06c

chaserileyroberts force-pushed the chase/stream_call_noinline branch from 5ac671a to 8ecc06c Compare

October 28, 2024 18:24

golechwierowicz approved these changes

View reviewed changes

golechwierowicz reviewed

View reviewed changes

xla/service/call_inliner_test.cc

    
                )");

                TF_ASSERT_OK(filecheck_result.status());

                EXPECT_TRUE(*filecheck_result);

Member

golechwierowicz Oct 29, 2024

For the future: I think everything below that can be deleted, because it's already tested via filecheck.

Member

frgossen Nov 1, 2024

+1

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

c06e31a

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot mentioned this pull request

PR #18448: Optionally don't inline stream annotated kCalls #18831

Merged

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

ff2b6e3

Imported from GitHub PR openxla/xla#18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c64422558094c5d1a913d4b425ca453435 by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c64422558094c5d1a913d4b425ca453435
PiperOrigin-RevId: 691070675

copybara-service bot mentioned this pull request

PR #18448: Optionally don't inline stream annotated kCalls tensorflow/tensorflow#78968

Merged

frgossen approved these changes

View reviewed changes

xla/service/call_inliner_test.cc

    
                )");

                TF_ASSERT_OK(filecheck_result.status());

                EXPECT_TRUE(*filecheck_result);

Member

frgossen Nov 1, 2024

+1

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

c2fd72c

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

6cd80d2

Imported from GitHub PR openxla/xla#18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c64422558094c5d1a913d4b425ca453435 by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c64422558094c5d1a913d4b425ca453435
PiperOrigin-RevId: 691070675

loislo self-requested a review

November 4, 2024 13:35

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

a774148

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

6b3cf9c

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

aeb042c

Imported from GitHub PR openxla/xla#18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c64422558094c5d1a913d4b425ca453435 by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c64422558094c5d1a913d4b425ca453435
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

0163a97

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

187dd34

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

0ad834e

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

99950cc

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

5873e46

Imported from GitHub PR openxla/xla#18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c64422558094c5d1a913d4b425ca453435 by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c64422558094c5d1a913d4b425ca453435
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

2ed03b9

Imported from GitHub PR #18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c
PiperOrigin-RevId: 691070675

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

57f2770

Imported from GitHub PR openxla/xla#18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c64422558094c5d1a913d4b425ca453435 by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c64422558094c5d1a913d4b425ca453435
PiperOrigin-RevId: 691070675

copybara-service bot closed this in

151c19d

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          PR #18448: Optionally don't inline stream annotated kCalls

5722d0a

Imported from GitHub PR openxla/xla#18448

First part of splitting up #17982
Copybara import of the project:

--
8ecc06c64422558094c5d1a913d4b425ca453435 by chaser <[email protected]>:

Don't inline stream annotated kCalls

Merging this change closes #18448

PiperOrigin-RevId: 694522066

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request


          Make TritonSupportTest surface sanitizer issues

3b114b4

TritonSupportTest relies on a death test for some of its assertion because Triton doesn't allow graceful error handling for some of the cases we want to test.

This death test also used to succeed when the code under test triggered a santizer violation.

So this change makes it fail on those sanitizer violations and will be surface those in the log.

Ideally we would tightly control in which code path each death test terminates, but unfortunately most of them don't have indicative error message. Some just call `std::abort` without an error message. Some just die in accessing an empty `std::optional`, etc. So the best we can do is make sure that we detect sanitizer errors and report these as test failures.

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18448 from chaserileyroberts:chase/stream_call_noinline 8ecc06c64422558094c5d1a913d4b425ca453435
PiperOrigin-RevId: 688604240

copybara-service bot mentioned this pull request

Make TritonSupportTest surface sanitizer issues tensorflow/tensorflow#78886

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet