Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chlo legalize to stablehlo #1967

Closed

Conversation

linuxlonelyeagle
Copy link
Contributor

No description provided.

@linuxlonelyeagle
Copy link
Contributor Author

Regarding the reason for submitting this PR.

@GleasonK
Copy link
Member

GleasonK commented Feb 1, 2024

Hello!

Thanks again for the contributions 😄! I have lumped this PR and the canonicalizers one into a single RFC:
[RFC] Adding StableHLO transformations for CHLO, Shape, Canonicalizations

The early feedback on this RFC is positive, so it seem plausible that we can proceed with these changes. If you have bandwidth, I think the proper / simpler solution would be to upstream the following CHLO files from IREE:

  • CHLODecompositionPatterns.td
  • LegalizeCHLO.cpp
  • Build targets for CHLO
  • tests in Conversion/test/legalize_chlo_*.mlir

If not, I'll do my best to prioritize upstreaming in the coming weeks!

@linuxlonelyeagle
Copy link
Contributor Author

Thanks!I'll get it done.

@linuxlonelyeagle
Copy link
Contributor Author

close by 1984.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants