Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize VHLO .td files #944

Closed
atondwal opened this issue Jan 19, 2023 · 1 comment · Fixed by #945
Closed

Reorganize VHLO .td files #944

atondwal opened this issue Jan 19, 2023 · 1 comment · Fixed by #945
Assignees
@atondwal
Labels
Compatibility Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit

Comments

@atondwal
Copy link
Contributor

llvm/llvm-project@3e731af limits interface generation to the top-level input file, so StableHLO will need to adapt.

cf tensorflow/tensorflow@225542e
@burmako burmako added the Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit label Jan 19, 2023
@burmako burmako changed the title Export VhloDialect Reorganize VHLO .td files Jan 19, 2023
@atondwal atondwal mentioned this issue Jan 19, 2023
Merged
@atondwal atondwal assigned atondwal and unassigned GleasonK Jan 19, 2023
@atondwal
Copy link
Contributor Author

Ah, sorry maybe I've crossed streams between this and @GleasonK 's #849 ? I'm just trying to port back the changes from tf's copy of stablehlo here.

GleasonK pushed a commit to GleasonK/stablehlo that referenced this issue Feb 10, 2023
@atondwal @GleasonK
Reorganize VHLO .td files (openxla#945)
48ca80d 
Fixes openxla#944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atondwal atondwal

Labels
Compatibility Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganize VHLO .td files atondwal/stablehlo
3 participants
@atondwal @burmako @GleasonK