Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forked types and attributes for VHLO #674

Closed
GleasonK opened this issue Dec 2, 2022 · 0 comments · Fixed by #849
Closed

Add forked types and attributes for VHLO #674

GleasonK opened this issue Dec 2, 2022 · 0 comments · Fixed by #849
Assignees
@GleasonK
Labels
Compatibility

Comments

@GleasonK
Copy link
Member

GleasonK commented Dec 2, 2022 •
edited
Loading

Request description

VHLO (Versioned StableHLO, #278) is the portable serialization dialect that will be used for providing compatible StableHLO artifacts across versions. An important aspect of this is to control the serialization of all upstream types used, as such VHLO should only use forks of all upstream types used in the dialect.
@GleasonK GleasonK mentioned this issue Dec 2, 2022
Closed
@GleasonK GleasonK changed the title Add forked types for VHLO Add forked types and attributes for VHLO Dec 5, 2022
@GleasonK GleasonK self-assigned this Dec 9, 2022
@GleasonK GleasonK mentioned this issue Dec 13, 2022
Merged
GleasonK added a commit that referenced this issue Dec 20, 2022
@GleasonK
Use AnyType and AnyAttr for all types and attributes in VHLO (#765)
cba63b4 
VHLO is intended to be a representation of the IR format, not an exact
typed dialect, as such use AnyType/AnyAttr everywhere. This change makes
use of AnyType for all types.

The definition of AnyType can be updated to only include VHLO types,
`AnyVhloType`, but this isn't necessary and should follow the work
regarding forked types and attrs (#674).

Could not use `AnyAttr` for `DefaultValued` fields since the constructor
of the attribute is required to accept the default value, so there are
some remnants of `DefaultValuedStringAttr`. I also did not update
`Shape_WitnessType` since that type needs to be forked. That update will
come in the forking types PR.

Closes #734.

Note this PR is built on top of versioned attributes/types (#736) and
should be reviewed/submitted after. Can [use this
diffbase](https://github.com/openxla/stablehlo/pull/765/files/cee7cd6ca7c96525239d51e199a079348054d221..0c0eb99b94bbd1d5883c1fbaeb83617564aa96d9)
or wait until other is merged to review.
@GleasonK GleasonK mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GleasonK GleasonK

Labels
Compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fork Attributes and Types for VHLO GleasonK/stablehlo
1 participant
@GleasonK