fix(openxAnalyticsAdaptor): fixed bug where slotloaded event does not always fire #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimee02
commented
Apr 28, 2020
jimee02
commented
- added payloadWaitTimePadding
- added auction state
- added auction endTime
hrgui
reviewed
Apr 28, 2020
| .withArgs('hb_adid') | ||
| .returns(highestBid ? [highestBid.adId] : []) | ||
| } | ||
| if(eventType === SLOT_LOADED) { |
There was a problem hiding this comment.
space after if, to stay consistent with the rest?
Perhaps Prebid should just use Prettier to ensure a consistency across all of the JS files.
hrgui
reviewed
Apr 28, 2020
modules/openxAnalyticsAdapter.js
Outdated
|
|
||
| if(auctionId && eventStack[auctionId] && eventStack[auctionId].events) { | ||
|
|
||
| if (auctionId && eventStack[auctionId] && eventStack[auctionId].events) { |
There was a problem hiding this comment.
Do we know if Prebid uses the latest babel?
This could be simplified to if (auctionId && eventStack?.[auctionId]?.events). If not then this is fine.
hrgui
approved these changes
Apr 28, 2020
… always fire * added payloadWaitTimePadding * added auction state * added auction endTime
jimee02
force-pushed
the
fix-v2-payload-sends-on-auction-end
branch
from
bfe2dc2
to
c807359
Compare
jimee02
pushed a commit
that referenced
this pull request
May 7, 2020
* add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <[email protected]> Co-authored-by: Gaby <[email protected]> Co-authored-by: fgcloutier <[email protected]> * Remove trailing-space * Fix version in tests Co-authored-by: Gaby <[email protected]> Co-authored-by: fgcloutier <[email protected]>
kenan-gillet
pushed a commit
that referenced
this pull request
Mar 23, 2021
prebid#6442) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <[email protected]> Co-authored-by: Gaby <[email protected]> Co-authored-by: fgcloutier <[email protected]> * Remove trailing-space * Fix version in tests * sublimeAdapter: Improve pixels data * sublimeAdapter: Update tests * sublimeAdapter: Rename data Co-authored-by: Gaby <[email protected]> Co-authored-by: Léo <[email protected]> Co-authored-by: fgcloutier <[email protected]> Co-authored-by: Léo GRAND <[email protected]>
laurb9
pushed a commit
that referenced
this pull request
Sep 5, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting --------- Co-authored-by: Jeremy Sadwith <[email protected]>
marcin-wrobel-ox
pushed a commit
that referenced
this pull request
Oct 31, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <[email protected]> * Reducing the size of Site object. * remove white space that is causing linting error --------- Co-authored-by: Jeremy Sadwith <[email protected]> Co-authored-by: Julian Gan <[email protected]>
marcin-wrobel-ox
pushed a commit
that referenced
this pull request
Oct 31, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <[email protected]> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval --------- Co-authored-by: Julian Gan <[email protected]> Co-authored-by: Neil Flynn <[email protected]>
marcin-wrobel-ox
pushed a commit
that referenced
this pull request
Oct 31, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <[email protected]> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval * Support for sending ortb2.user.data --------- Co-authored-by: Julian Gan <[email protected]> Co-authored-by: Neil Flynn <[email protected]>
laurb9
pushed a commit
that referenced
this pull request
Jul 30, 2024
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <[email protected]> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval * Support for sending ortb2.user.data * update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service * Prebid.js - Update bid Response to use actual creativeID (#25) * update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service * utilize floors mod * fixes tests * mediatype specific floors * simpler implementation leveraging Prebid's smart rule selection * revert nomenclature change * fix * removes comment --------- Co-authored-by: Jeremy Sadwith <[email protected]> Co-authored-by: Julian Gan <[email protected]> Co-authored-by: Neil Flynn <[email protected]> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: Nick Llerandi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.