Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-statsd-exporter: fix compilation with go 1.11.4 #7857

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

dhewg
Copy link
Contributor

@dhewg dhewg commented Jan 3, 2019

Maintainer: @dhewg
Compile tested: arm/sunxi, Cubieboard 2, master
Run tested: arm/sunxi, Cubieboard 2, master

Description:
This fixes the exact same build error reported at [0].
Upstream fixed it too, see [1], but I decided to use the minimal patch
until a new version is released instead.

[0] golang/go#29281
[1] prometheus/statsd_exporter#171

Signed-off-by: Andre Heider [email protected]

@thess
Copy link
Member

thess commented Jan 3, 2019

Please bump either PKG_VERSION or PKG_RELEASE.
By the way -- I am not the maintainer of any GO related packages. Don't assign them to me.

@dhewg
Copy link
Contributor Author

dhewg commented Jan 4, 2019

Oh, my bad, I used the wrong user id. The go update was done by @jefferyto
It probably makes sense for me to take ownership of this package

dhewg added 2 commits January 4, 2019 07:33
This fixes the exact same build error reported at [0].
Upstream fixed it too, see [1], but I decided to use the minimal patch
until a new version is released instead.

[0] golang/go#29281
[1] prometheus/statsd_exporter#171

Signed-off-by: Andre Heider <[email protected]>
@dhewg dhewg force-pushed the pull/prometheus-statsd-exporter branch from 69c6eb2 to 9fadc6b Compare January 4, 2019 06:34
@hnyman hnyman merged commit 180d9ba into openwrt:master Jan 5, 2019
@dhewg dhewg deleted the pull/prometheus-statsd-exporter branch January 6, 2019 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants