quasselc: Update to latest commit #7454
Conversation
|
You can also use codeload |
|
This is not a tagged release. |
|
You can still use codeload though if you want |
|
Yeah sure why not. Added some minor adjustments as well. |
|
I just realized quassel-irssi is using this as a submodule. It might make sense to get rid of this package. |
|
Hey, thanks for looking at this. I admit I haven't really had the time to stay on top of quassel-irssi in openwrt. Do I need to do to something to sign off on PRs? I unbundled quasselc here because I unbundled it in Fedora, too (where I am also the maintainer)-- in theory, other software could have wanted to use libquasselc. In practice, that hasn't happened, and the upstream project isn't super active anyway so... re-bundling this with quassel-irssi may make sense. |
|
Ehhh no. LGTM or whatever works. Does other software in Fedora use quasselc? |
|
No, it's just standard policy to try and unbundle where possible. |
|
@hnyman As the irssi variant is now using the bundled version, this package is obsolete. CircleCI can't handle package removal seems like. |
Switched to codeload for simpler Makefile. Several adjustments for consistency. Signed-off-by: Rosen Penev <[email protected]>
|
Since this package doesn't want to get removed, I updated it instead, as was originally done. Rebased against current master as well. |
|
@neheb for this sort of package I don't have complaints about less than fully tested updates because otherwise it's just bitrot -- with maintainers who aren't as active as you'd like (but who do participate) I think more patience ought to be in play. Life happens to maintainers and I know I'd be rather annoyed if I was on vacation or a couple weeks and found out that packages had non-urgent stuff pushed, especially if it wasn't something I'd haved acked as-is. |
|
Maintainer previously ACKed this. Upstream is basically dead. Only one package uses this. |
|
@neheb er, I was agreeing with you on this sort of package, given the lack of appetite for removal even when it's pretty obvious it's warranted (IMO). |
|
Guys, okay. Its pretty obvious to remove it. Time changed, things happened. Let's get rid of it. I will prepare PR. |
Signed-off-by: Rosen Penev [email protected]
Maintainer: @TC01
Compile tested: mvebu